Skip to content

Collapse -success and -failure jobs into an -outcome job#124014

Closed
emilyalbini wants to merge 1 commit into
rust-lang:masterfrom
emilyalbini:pa-remove-jobs
Closed

Collapse -success and -failure jobs into an -outcome job#124014
emilyalbini wants to merge 1 commit into
rust-lang:masterfrom
emilyalbini:pa-remove-jobs

Conversation

@emilyalbini

Copy link
Copy Markdown
Member

Before this commit we had auto-success, auto-failure, try-success and try-failure. The only difference between a -success and a -failure job though was the exit code that was returned in the job.

To reduce clutter, this PR collapses each pair of jobs into a single job that is executed regardless of whether the dependency jobs passed or failed. Then a simple jq invocation checks whether the dependencies passed or failed to determine the exit code.

r? @Kobzol

Before this commit we had auto-success, auto-failure, try-success and
try-failure. The only difference between a -success and a -failure job
though was the exit code that was returned in the job.

To reduce clutter, this PR collapses each pair of jobs into a single
job that is executed regardless of whether the dependency jobs passed or
failed. Then a simple jq invocation checks whether the dependencies
passed or failed to determine the exit code.
@rustbot

rustbot commented Apr 16, 2024

Copy link
Copy Markdown
Collaborator

Could not assign reviewer from: Kobzol.
User(s) Kobzol are either the PR author, already assigned, or on vacation. If it's a team, we could not find any candidates.
Please use r? to specify someone else to assign.

@rustbot

rustbot commented Apr 16, 2024

Copy link
Copy Markdown
Collaborator

@pietroalbini: no appropriate reviewer found, use r? to override

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 16, 2024
@rustbot

rustbot commented Apr 16, 2024

Copy link
Copy Markdown
Collaborator

Kobzol has insufficient capacity to be assigned the pull request at this time. PR assignment has been reverted.

Please choose another assignee.

(see documentation)

@emilyalbini

Copy link
Copy Markdown
Member Author

r? @Kobzol

@@ -290,20 +290,11 @@ x--expand-yaml-anchors--remove:
- &base-outcome-job

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment above this isn't updated (it still mentions try-success etc.)

<<: *base-success-job
auto-failure:
# !cancelled() executes the job regardless of whether it passed or failed
if: "!cancelled() && github.event_name == 'push' && (github.ref == 'refs/heads/try' || github.ref == 'refs/heads/try-perf') && github.repository == 'rust-lang-ci/rust'"

@Kobzol Kobzol Apr 16, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking out loud: do we actually need this if (more specifically, the github.XXX parts? Shouldn't this job be skipped automatically if try (which it needs) is skipped?

@Kobzol

Kobzol commented Apr 22, 2024

Copy link
Copy Markdown
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2024
@bors

bors commented Apr 24, 2024

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #124175) made this pull request unmergeable. Please resolve the merge conflicts.

@emilyalbini

Copy link
Copy Markdown
Member Author

Superseded by #124366.

@emilyalbini emilyalbini deleted the pa-remove-jobs branch May 9, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants